Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SubmittedAt field to PullRequestReview #1964

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Add SubmittedAt field to PullRequestReview #1964

merged 1 commit into from
Jun 16, 2019

Conversation

ryangribble
Copy link
Contributor

@ryangribble ryangribble commented May 22, 2019

Field isnt shown in responses on the developer docs site, however poking the API shows it IS present in the json response payload and is thus populated successfully with this change

image

@ryangribble
Copy link
Contributor Author

release_notes: Implement SubmittedAt field on PullRequestReview response model

@shiftkey
Copy link
Member

Nice spot - will see if I can raise this with the right team internally to update the docs

@martinnormark
Copy link

Any chance this will be merged soon?

@ryangribble ryangribble merged commit 9f005c4 into master Jun 16, 2019
@ryangribble ryangribble deleted the review-date branch June 16, 2019 21:26
@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants