Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Review is missing submitted_at property #1969

Closed
dicko2 opened this issue Jun 16, 2019 · 1 comment
Closed

Pull Request Review is missing submitted_at property #1969

dicko2 opened this issue Jun 16, 2019 · 1 comment

Comments

@dicko2
Copy link

dicko2 commented Jun 16, 2019

public class PullRequestReview

What is strange about this though is this field is also missing from the github documentation.

https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request

I can see it clearly in the API response however.

  {
    "id": 409120,
    "node_id": "xxx",
    "user": {
      "login": ".."
    },
    "body": "",
    "state": "COMMENTED",
    "html_url": "https://...",
    "pull_request_url": "https://...",
    "author_association": "MEMBER",
    "_links": {
      "html": {
        "href": "https://..."
      },
      "pull_request": {
        "href": "https://..."
      }
    },
    "submitted_at": "2019-04-29T05:52:36Z",
    "commit_id": "xxx"
  },

This is from our GitHub Enterprise instance, though i don't think it makes much of a difference.

@ryangribble
Copy link
Contributor

I actually ran into this myself a few weeks ago and added it, forgot to merge though 😊 - #1964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants