Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing OAuth login request parameters #1919

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Adds missing OAuth login request parameters #1919

merged 1 commit into from
Jan 30, 2019

Conversation

patriksvensson
Copy link
Contributor

  • Adds support for 'login' parameter
  • Adds support for 'allow_signup' parameter

Closes #1918

@patriksvensson
Adds missing OAuth login request parameters
0060f31 
* Adds support for 'login' parameter
* Adds support for 'allow_signup' parameter

Closes #1918
@ryangribble
Copy link
Contributor

release_notes: Add additional optional fields Login and AllowSignup to OauthLoginRequest request

@ryangribble
Copy link
Contributor

LGTM

Thanks @patriksvensson sorry for not getting back to this earlier 🙏

@ryangribble ryangribble merged commit 64cecbb into octokit:master Jan 30, 2019
@nickfloyd nickfloyd added Type: Feature New feature or request and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patriksvensson @ryangribble @shiftkey @nickfloyd