Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing login and allow_signup parameter to OauthLoginRequest #1918

Closed
patriksvensson opened this issue Dec 1, 2018 · 1 comment
Closed

Add missing login and allow_signup parameter to OauthLoginRequest #1918

patriksvensson opened this issue Dec 1, 2018 · 1 comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@patriksvensson
Copy link
Contributor

It would be great if the (optional) login and allow_signup parameters was present on the OauthLoginRequest class.

Documentation for this can be found here: https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/#parameters

I would be happy to submit a PR for this.
@ryangribble
Copy link
Contributor

Hi @patriksvensson, some of these older endpoints or requests have had fields added to them over time which we've missed in octokit!

It would be awesome if you want to send in a PR.

FYI our convention for optional fields is they should be nullable and should be set via object initialisation syntax (ie not via the ctor) if that helps! 🙏

@patriksvensson patriksvensson mentioned this issue Dec 2, 2018
Merged
ryangribble pushed a commit that referenced this issue Jan 30, 2019
@patriksvensson @ryangribble
Adds missing OAuth login request parameters (#1919)
64cecbb 
* Adds support for 'login' parameter
* Adds support for 'allow_signup' parameter

Closes #1918
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nickfloyd @patriksvensson @shiftkey @ryangribble