-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repository settings to configure PR merge methods #1477
Conversation
…der and fix impacted unit tests
…t! Have contact GH support as it seems to be an upstream problem)
…ent.Edit() method to specify preview accepts header and fix impacted unit tests Also added some checking for RepositoryUpdate.Name being null, as it is a required parameter
Github support replied and confirmed there was some upstream problems which they've pushed fixes for. With those fixes, the Get and Update integration tests I added are now passing 👍 Still seems to be an issue with Create call which I've asked support to look into |
Support reply regarding create method:
So I'll remove the create method tomorrow then this PR can be merged |
….Create() method to specify preview accepts header and fix impacted unit tests Add integration test for Create Repository with merge method specified
… by the github API This reverts commit cf4c78c
aabc3a3
to
de3e809
Compare
OK this is now good to go, I've removed the |
I'm impatient and Travis is having issues
|
Fixes #1475
(confirmed no other methods like GetAllForCurrent, GetAllPublic, GetAllForOrg return the new fields even when accepts header is provided, so only the individual Get Repository call needs to be implemented)
(support confirmed this was a documentation error and Create Repository call does not support these parameters)
I've had to contact GitHub support as the new fields aren't actually being returned but I'm pretty sure everything is correct on my side...