Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository settings to configure PR merge methods #1477

Merged
merged 7 commits into from
Oct 4, 2016

Conversation

ryangribble
Copy link
Contributor

@ryangribble ryangribble commented Sep 28, 2016

Fixes #1475

  • Add new options to Get Repository methods
  • Poke API to figure out whether any of the GetAll (for Current, Public, For Organization, etc) methods return these new fields (despite API docs not mentioning it) and implement if so

(confirmed no other methods like GetAllForCurrent, GetAllPublic, GetAllForOrg return the new fields even when accepts header is provided, so only the individual Get Repository call needs to be implemented)

  • Add new options to Create Repository request
  • Add new options to Edit Repository request
  • Waiting for github support to advise regarding Create Repository call still not appearing to support the new fields

(support confirmed this was a documentation error and Create Repository call does not support these parameters)

I've had to contact GitHub support as the new fields aren't actually being returned but I'm pretty sure everything is correct on my side...

ryangribble and others added 5 commits September 29, 2016 09:45
…t! Have contact GH support as it seems to be an upstream problem)
…ent.Edit() method to specify preview accepts header and fix impacted unit tests

Also added some checking for RepositoryUpdate.Name being null, as it is a required parameter
@ryangribble
Copy link
Contributor Author

ryangribble commented Oct 1, 2016

Github support replied and confirmed there was some upstream problems which they've pushed fixes for.

With those fixes, the Get and Update integration tests I added are now passing 👍

Still seems to be an issue with Create call which I've asked support to look into

@ryangribble
Copy link
Contributor Author

Support reply regarding create method:

Turns out that this isn't a problem in the code, but the documentation -- it was originally intended for the feature to be supported by the endpoints to fetch and modify a repository, even though the documentation says it should be supported by the endpoint for creating a repository (the documentation shouldn't have said that). We'll be updating the documentation to reflect this.

So I'll remove the create method tomorrow then this PR can be merged

@shiftkey shiftkey mentioned this pull request Oct 4, 2016
9 tasks
ryangribble and others added 2 commits October 5, 2016 07:51
….Create() method to specify preview accepts header and fix impacted unit tests

Add integration test for Create Repository with merge method specified
@ryangribble
Copy link
Contributor Author

OK this is now good to go, I've removed the CreateRepository changes, but left the commit in the history incase github do end up supporting it, we can resurrect it

@ryangribble ryangribble changed the title [WIP] Add repository settings to configure PR merge methods Add repository settings to configure PR merge methods Oct 4, 2016
@shiftkey
Copy link
Member

shiftkey commented Oct 4, 2016

I'm impatient and Travis is having issues

#yolo

@shiftkey shiftkey merged commit feb7561 into octokit:master Oct 4, 2016
@ryangribble ryangribble deleted the repo-merge-options branch January 15, 2017 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants