-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ApiOption overloads to methods on I(Observable)RepositoryPagesClient #1304
Added ApiOption overloads to methods on I(Observable)RepositoryPagesClient #1304
Conversation
…s well as Reactive methods and added tests
@ryangribble can I get a 👍 here before I merge this in? |
Looks pretty good, although I didn't see integration tests that actually test the pagination... Is that because there isn't a suitable repo that has enough responses? |
@ryangribble it's because anything related to Pages requires the account to be an administrator of the repository: #1263 |
Yeah I saw the existing test was skipped, I guess I was just questioning whether there should still be the pagination test written, then also skipped? The code changes look fine though so 👍 if you aren't concerned about the missing test |
@ryangribble good point. I'll add the test so we don't forget it and then close this out... |
Fixes #1178
Supersedes #1213 and addresses merge conflict