Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApiOption overloads to methods on IRepositoryPagesClient #1178

Closed
1 task
shiftkey opened this issue Mar 14, 2016 · 0 comments
Closed
1 task

Add ApiOption overloads to methods on IRepositoryPagesClient #1178

shiftkey opened this issue Mar 14, 2016 · 0 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

As part of completing #760 a number of overloads need to be added to the client interfaces.

As an example, this has been added to IReleasesClientand IObservableReleasesClient.

The checklist for porting each method is:

  • Add an overload for this method on IRepositoryPagesClient with a new parameter ApiOptions
  • Implement the new method on the class which implements IRepositoryPagesClient
  • Add an overload for this method on IObservableRepositoryPagesClient with a new parameter ApiOptions
  • Implement the new method on the class which implements IObservableRepositoryPagesClient

This needs to be done for each of these methods:

  • Task<IReadOnlyList<PagesBuild>> GetAll(String owner, String repositoryName)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

2 participants