-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApiOption overloads to IIssuesClient and IObservableIssuesClient #1274
Conversation
IIssuesClient
and IObservableIssuesClient
await Assert.ThrowsAsync<ArgumentNullException>( | ||
() => client.GetAllForOwnedAndMemberRepositories(null, new ApiOptions())); | ||
await Assert.ThrowsAsync<ArgumentNullException>( | ||
() => client.GetAllForOwnedAndMemberRepositories(new IssueRequest(), null)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really minor nitpick but the equivalent code in other unit tests in this file are all on one line, while these ones are indented/split...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 just my 80-chars-per-line OCD acting up. I'll undo this.
it's hard to review these changes, but Im grasping at straws to find anything major here 😀 |
@ryangribble thanks for the 👀, I think there's a bunch of new test coverage here I can do but given how many overloads there are I'm trying to keep this as focused as possible. |
77d722f
to
c9f4e54
Compare
I also took some time out in 1b2d009 to document the return values from the API. Let me know if you have any feedback on the words. |
Lots of the pagination endpoints here require you to have org access, so rather than getting too bogged down in pagination I'm going to skip those tests. |
I noticed you are using The wording sounds reasonable although I wonder whether the effort involved to doc all return values is worth it, since they are pretty self evident... and it then sorta means we have to go and add them to allll the rest of the codebase. I guess the same could be said for doccing most parameters in general though and if we didnt do it then we would have no doc anywhere. Does this mean you intend us to start the process of docing return value on everything from now on? |
cf76517
to
ac01e40
Compare
Can I get a 👍 here before I close this out? |
Fixes #1158
This is a big one, so I'm going through it as slowly and methodically as possible: