Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApiOption overloads to methods on IIssuesClient #1158

Closed
8 tasks
shiftkey opened this issue Mar 14, 2016 · 0 comments
Closed
8 tasks

Add ApiOption overloads to methods on IIssuesClient #1158

shiftkey opened this issue Mar 14, 2016 · 0 comments
Assignees
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

As part of completing #760 a number of overloads need to be added to the client interfaces.

As an example, this has been added to IReleasesClientand IObservableReleasesClient.

The checklist for porting each method is:

  • Add an overload for this method on IIssuesClient with a new parameter ApiOptions
  • Implement the new method on the class which implements IIssuesClient
  • Add an overload for this method on IObservableIssuesClient with a new parameter ApiOptions
  • Implement the new method on the class which implements IObservableIssuesClient

This needs to be done for each of these methods:

  • Task<IReadOnlyList<Issue>> GetAllForCurrent()
  • Task<IReadOnlyList<Issue>> GetAllForCurrent(IssueRequest request)
  • Task<IReadOnlyList<Issue>> GetAllForOrganization(String organization)
  • Task<IReadOnlyList<Issue>> GetAllForOrganization(String organization, IssueRequest request)
  • Task<IReadOnlyList<Issue>> GetAllForOwnedAndMemberRepositories()
  • Task<IReadOnlyList<Issue>> GetAllForOwnedAndMemberRepositories(IssueRequest request)
  • Task<IReadOnlyList<Issue>> GetAllForRepository(String owner, String name)
  • Task<IReadOnlyList<Issue>> GetAllForRepository(String owner, String name, RepositoryIssueRequest request)
@shiftkey shiftkey added this to the Pagination Support milestone Mar 14, 2016
@shiftkey shiftkey self-assigned this Apr 19, 2016
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

2 participants