Fix for #1104 (configure-integration-tests.ps1) #1118
Conversation
Made changes in configure-integration-tests.ps1. For an optional value it gives the option to change or remove the value, for a necessary value it doesn't give an option.
|
While we're in here, could you look at making the whitespace consistent? It's probably my fault that there's some inconsistencies in here... |
| } | ||
| else | ||
| { | ||
| $reset = Read-Host -Prompt "Want to change this value , press Y, otherwise we'll move on" |
There was a problem hiding this comment.
Let's tweak this message: Press Y to change this value, otherwise we'll move on
|
@Anubhav10 this looks good - just that one improvement to the message and some cleanup of the whitespace and I think this is good to go! |
| @@ -1,4 +1,4 @@ | |||
| # TODO: this should indicate whether a variable is required or optional | |||
| # TODO: this should indicate whether a variable is required or optional | |||
There was a problem hiding this comment.
This is an old comment from before I actually implemented the optional parameters. Feel free to remove this 🔥
|
I'll do the suggested changes. Yesterday, the Travis CI build was failing, how come it passed today? I tried to understand why it was failing but I couldn't. |
|
Unfortunately we are sometimes seeing unrelated failures on the linux and/or OSX travis CI builds. |
made white spaces consistent and changed the message
|
@shiftkey The whitespace inconsistency was in my code and was my fault. I have removed the TODO comment and changed the message. |
|
@Anubhav10 excellent, thanks for this!
|
ryangribble
changed the title
Made changes in .\script\configure-integration-tests.ps1.
For an optional value it gives the option to change or remove the value, for a necessary value it doesn't give an option.
Fixes #1104