Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure-integration-tests tries to remove a value right after I set it #1104

Closed
shiftkey opened this issue Feb 11, 2016 · 2 comments
Closed
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

This flow around optional values seems counter-intuitive:

[value] found as the configured application Secret
Want to change this? Press Y, otherwise we'll move on:
y
Change the application Secret to use for the integration tests: [new-value]
Want to remove this optional value, press Y:

If the user has pressed Y here, Want to remove... shouldn't be an option...

@nubby109
Copy link
Contributor

nubby109 commented Mar 6, 2016

I have fixed the issue. For an optional value it gives the option to change or remove the value, for a necessary value it doesn't give an option. this is how it looks like now.

powershell

Please tell me if its what you wanted, and I'll send a pull request.

the files at the top has a TODO-" # TODO: this should indicate whether a variable is required or optional." It indicates if the property if required or optional when setting the value, where else should it indicate?

@shiftkey
Copy link
Member Author

shiftkey commented Mar 6, 2016

@Anubhav10 that sounds like it's on the right track - I'd love to review the work you've done here...

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants