Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for RepoCollab client #1051

Conversation

M-Zuber
Copy link
Contributor

@M-Zuber M-Zuber commented Dec 28, 2015

I've added 2 tests and hope to add more. Just want to make sure that I am on the right track.
fixes #1045

Review on Reviewable

@M-Zuber M-Zuber changed the title [WIP] Add integration tests for RepoCollab client Add integration tests for RepoCollab client Jan 3, 2016
@M-Zuber
Copy link
Contributor Author

M-Zuber commented Jan 3, 2016

I am not sure why the builds are failing :(

I did not add a separate test for the Add method as it is used in both tests already written.
Also there is no test for the delete method - should it be added?

@shiftkey
Copy link
Member

Just nudged the problem builds and it's now all good. Will keep an eye out for other flakiness.

shiftkey added a commit that referenced this pull request Jan 12, 2016
…integration.tests

Add integration tests for RepoCollab client
@shiftkey shiftkey merged commit f3035de into octokit:master Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add some tests for Repository.Collaborator
2 participants