Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some tests for Repository.Collaborator #1045

Closed
shiftkey opened this issue Dec 23, 2015 · 4 comments · Fixed by #1051
Closed

add some tests for Repository.Collaborator #1045

shiftkey opened this issue Dec 23, 2015 · 4 comments · Fixed by #1051
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

Reported here: #1040 (comment)

BTW I noticed that there seems to be no tests for this property. Is this on purpose?

It'd be nice to get some integration tests in here - mostly to verify that we're able to retrieve and deserialize details about the collaborators - as a regression test.

@M-Zuber
Copy link
Contributor

M-Zuber commented Dec 24, 2015

I'll take this.
(only right as it's my fault it is here 😛)

@M-Zuber
Copy link
Contributor

M-Zuber commented Dec 27, 2015

okay, so this seems to be quite complicated (and possibly the reason tests were not written previously)
You can not get collaborator data if you do not have push access to the repository.
@shiftkey what do you say?

@shiftkey
Copy link
Member Author

@M-Zuber you might be right - from the docs:

Otherwise, only users with access to the repository are returned in the collaborators list.

I suspect pull wouldn't give you much data, but I haven't looked into it.

To test this out, you could use a newly-created repository and add/remove collaborators from there before tearing it down...

@M-Zuber
Copy link
Contributor

M-Zuber commented Dec 27, 2015

Thanks for that input.
Well I guess I am going to sacrifice my user to lots of notifications :) (or make yet another one :)
Hope to get to this soon

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants