IRepositoriesClient.RepoCollaborators -> IRepositoriesClient.Collaborator #1040
Conversation
|
@M-Zuber I think you can make this change without renaming types - perhaps some extra changes are causing the build failures to creep in... |
|
Okay, so the wanted change is just the properties on the |
Correct. Let's keep it simple!
If you're fine with force-pushing this branch to blow away the current changes, I'm fine with that. Otherwise just open a new PR. |
|
Force push is fun 😄 |
|
M-Zuber
changed the title
M-Zuber
force-pushed
the
Oboslete-IRepoCollaborators
branch
from
e8780b2 to
8d76a2f
Compare
| @@ -22,7 +22,10 @@ public ObservableRepositoriesClient(IGitHubClient client) | |||
| CommitStatus = new ObservableCommitStatusClient(client); | |||
| Hooks = new ObservableRepositoryHooksClient(client); | |||
| Forks = new ObservableRepositoryForksClient(client); | |||
| #pragma warning disable CS0618 // Type or member is obsolete | |||
There was a problem hiding this comment.
This ensures that current consumers won't get null
|
@shiftkey that gif more then accurately describes what I just went through CI y u no pas??? EDIT: I think I fixed him |
M-Zuber
force-pushed
the
Oboslete-IRepoCollaborators
branch
from
8d76a2f to
a7a1c01
Compare
| @@ -25,7 +25,10 @@ public RepositoriesClient(IApiConnection apiConnection) : base(apiConnection) | |||
| CommitStatus = new CommitStatusClient(apiConnection); | |||
| Hooks = new RepositoryHooksClient(apiConnection); | |||
| Forks = new RepositoryForksClient(apiConnection); | |||
| #pragma warning disable CS0618 // Type or member is obsolete | |||
M-Zuber
force-pushed
the
Oboslete-IRepoCollaborators
branch
from
a7a1c01 to
10c3b2a
Compare
|
BTW I noticed that there seems to be no tests for this property. Is this on purpose? |
No, likely just something that was overlooked. Tracking that in #1045 |
|
@M-Zuber thanks! |
IRepositoriesClient.RepoCollaborators -> IRepositoriesClient.Collaborator
Fixes #1036
Updated.