Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Octokit.net cannot handle mannequin users #2687

Closed
1 task done
asklar opened this issue Mar 20, 2023 · 3 comments · Fixed by #2694
Closed
1 task done

[BUG]: Octokit.net cannot handle mannequin users #2687

asklar opened this issue Mar 20, 2023 · 3 comments · Fixed by #2694
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@asklar
Copy link
Contributor

asklar commented Mar 20, 2023

What happened?

A long time ago, Python had its own bug database/git repository called BPO. Then they migrated to github. As part of the migration, they decided to not migrate their users and instead create "mannequin" accounts. Somehow this became a feature in GitHub: What on Earth is a “mannequin”?

We have a tool that uses octokit.net and looks through PRs/Issues. Our tool found a PR in the python/cpython repo, which was created by one of these mannequin accounts:
python/cpython#50246

Octokit.net does not know how to deal with these as they don't represent real users.

image

Versions

octokit.net 5.0.0

Relevant log output

![image](https://user-images.githubusercontent.com/22989529/226470814-1aa36bc6-7725-4c1d-bce6-4d4003c27918.png)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@asklar asklar added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Mar 20, 2023
@nickfloyd
Copy link
Contributor

Hey @asklar, thanks for reaching out. You are correct; the enterprise importer uses them as placeholders.

They do exist as enums (mostly) in the GitHub OpenAPI specification and therefore are valid values that can be passed into and out of our SDK - Octokit.net simply doesn't have this value implemented yet. This is because this particular SDK is hand built (we are working on generative solutions for it though). Let me know if this is something that you'd be interested in adding to whichever endpoint/model you are using.

I'll also add the up for grabs label to let the community know that they can pick it up as well.

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request and removed Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Mar 24, 2023
@nickfloyd nickfloyd moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Mar 24, 2023
@asklar
Copy link
Contributor Author

asklar commented Mar 24, 2023

thanks @nickfloyd - I'm building an app that uses octokit.net, call some API to fetch some details about a repo that the user asks for, and it just so happens they provided the python repo. There seems like there isn't much from the app's perspective that we can do to ignore/skip issues that have a mannequin user in them, it just fails the whole operation :-/

MGbiorczyk95 added a commit to MGbiorczyk95/octokit.net that referenced this issue Apr 6, 2023
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Apr 11, 2023
kfcampbell pushed a commit that referenced this issue Apr 11, 2023
* Added Mannequin account type for migrated repos

Fix issue #2687

* Update AccountType.cs

* Added information about mannequin account type
@asklar
Copy link
Contributor Author

asklar commented Apr 12, 2023

thanks @kfcampbell !! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants