Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a widget throws octokit exception #68

Closed
asklar opened this issue Mar 20, 2023 · 4 comments · Fixed by microsoft/devhomegithubextension#15
Closed

Adding a widget throws octokit exception #68

asklar opened this issue Mar 20, 2023 · 4 comments · Fixed by microsoft/devhomegithubextension#15
Assignees
Labels
Issue-Bug Something isn't working or needs investigation Resolution-Fix-Available Available in a release
Milestone

Comments

@asklar
Copy link
Member

asklar commented Mar 20, 2023

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce

image

might require a fix in octokit?

Expected behavior

No response

Actual behavior

No response

Included System Information

No response

@asklar asklar added the Issue-Bug Something isn't working or needs investigation label Mar 20, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Mar 20, 2023
@asklar
Copy link
Member Author

asklar commented Mar 20, 2023

doesn't happen all the time, might be a result of an issue falling out of the "top 10 pages" list?

@asklar
Copy link
Member Author

asklar commented Mar 20, 2023

this is an interesting bug :)

A long time ago, Python had its own bug database/git repository called BPO. Then they migrated to github. As part of the migration, they decided to not migrate their users and instead create "mannequin" accounts. Somehow this became a feature in GitHub: What on Earth is a “mannequin”?

the widget found a PR in the python/cpython repo, which was created by one of these mannequin accounts:
python/cpython#50246

Octokit.net does not know how to deal with these as they don't represent real users.

@dkbennett dkbennett self-assigned this Mar 22, 2023
@dkbennett
Copy link
Member

I will add additional exception handling around the Octokit calls for System.ArgumentException to ignore that record and continue. I think we need an Octokit fix for a permanent solution, but we should at least be able to catch & skip when this is encountered, and log it. Probably worthy of a telemetry event also.

@krschau
Copy link
Collaborator

krschau commented Apr 12, 2023

Octokit fix: octokit/octokit.net#2687
Not sure how quickly they put out releases https://github.com/octokit/octokit.net/releases (looks like potentially quite quickly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working or needs investigation Resolution-Fix-Available Available in a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants