Add footer tests #563
Closed
Add footer tests #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way I'm making this PR from a fork, not from within a branch that's already on the main repository. Gitpod doesn't allow me to push to any organization branch. I'll make a private discussion to debug this together. 😉 |
|
Can we move this to a branch within the repo now that we solved the gitpod issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by PR #575.
Changes
Context
This PR adds some more tests to check if we're actually displaying the wanted items in our footer. Right now it uses find by role, but it's not limited to checking the
<footer>section, so it's really checking if the page shows the item, not if the footer specifically contains the items.I need some help to get the Vercel badge test working properly. I cannot get it to accurately find the
srcto test that it uses the correct SVG image. I also cannot test thehrefthat comes with the Vercel badge.Tests
I've checked my work by: