Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tests fail right away on a PR coming from a fork #565

Open
HonkingGoose opened this issue Nov 17, 2021 · 1 comment
Open

Cypress tests fail right away on a PR coming from a fork #565

HonkingGoose opened this issue Nov 17, 2021 · 1 comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test f

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Nov 17, 2021

Describe the bug

Contributing to our project from a fork is not really working smoothly right now.
Cypress test fail with a message about the --record flag.

Give the steps to reproduce

  1. Create fork of octoclairvoyant-webapp
  2. Make changes on a new branch within the fork
  3. Open a PR upstream
  4. Cypress tests run (after first-time contributor approval)
  5. Cypress tests fail with:
    You passed the --record flag but this project has not been setup to record.
    
    This project is missing the 'projectId' inside of 'cypress.json'.
    
    We cannot uniquely identify this project without this id.
    
    You need to setup this project to record. This will generate a unique 'projectId'.
    
    Alternatively if you omit the --record flag this project will run without recording.

What browsers are you seeing the problem on?

Bug is not about browser

Have you thought of a possible solution?

Yes

If you have thought of a solution, please tell us about it!

Maybe we can distinguish between internal PRs and outsider PRs, and change things so we only run Cypress with the --record flag on internal PRs?

Do you want to help fix the bug?

No

Is there anything else we need to know?

Example of a PR coming from a fork: #563

@HonkingGoose HonkingGoose added bug Bug fix of existing functionality status:requirements labels Nov 17, 2021
@Belco90
Copy link
Member

Belco90 commented Nov 17, 2021

Which command are you using to run the E2E tests?

Ah sorry, this is when running the CI. I'll have to check what's the best way to deal with this.

@HonkingGoose HonkingGoose changed the title Cypress test fail right away on a PR coming from a fork Cypress tests fail right away on a PR coming from a fork Nov 18, 2021
@Belco90 Belco90 added chore Changes that affect the build system, CI config or other changes that don't modify src/test f and removed status:requirements bug Bug fix of existing functionality labels Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test f
Projects
Status: Todo
Development

No branches or pull requests

2 participants