Compiler: compile ocaml string as javascript ones #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
changed the title
|
all tests pass with ocaml/num#20 |
This was referenced Nov 25, 2019
|
Waiting for ocaml/num#20 to be released. |
hhugo
force-pushed
the
jsstring
branch
2 times, most recently
from
838dde7 to
c879830
Compare
hhugo
changed the title
|
@TyOverby, would you have time to review this ? |
hhugo
force-pushed
the
jsstring
branch
2 times, most recently
from
8a2640c to
724ffbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature requires that all deps use the right primitives to manipulate bytes and string.
Here is a PoC for typing some of the primitives known to the OCaml compiler
https://github.com/hhugo/ocaml/commits/prim-typ