Use %caml_bytes_set16u when it's available (with dune-configurator) #37
Conversation
|
/cc @hhugo of course. |
|
Even if it's a light PPX, I don't like to put an other dependence to |
|
For other libraries, we are simply bumping the upper bound (e.g. cstruct-unix is already 4.06+). Given that the base64 library is not changing rapidly, I'd prefer this to simply be upper bounded to 4.07+ and keep the complexity down. I can be convinced otherwise if you feel strongly that you do want this ppx and multiversion support PR merged, however :-) |
|
My concerns is mostly about external projects of MirageOS where some people use |
|
Hmmhmm, I think that we can use another mechanism with |
dinosaure
force-pushed
the
bytes_set16u
branch
from
9da991d to
6e7c2a5
Compare
dinosaure
changed the title
|
I think it's a good solution and it's work for |
CHANGES: - Remove `build` directive on dune dependency (@craigfe, mirage/ocaml-base64#35) - Make error poly-variant open (@copy, mirage/ocaml-base64#39) - Use `unsafe_bytes_set16u` instead `unsafe_string_set16u` (@dinosaure, @hhugo, @avsm, mirage/ocaml-base64#37)
According #36.