Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#813 Person profile attributes -> object within user #847

Merged
merged 8 commits into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ An example `vulnerability.json` object file,
```
"attributes": {
"$include": [
"profiles/person.json"
"profiles/host.json"
],
...
}
Expand Down
11 changes: 8 additions & 3 deletions dictionary.json
Original file line number Diff line number Diff line change
Expand Up @@ -1273,11 +1273,11 @@
"description": "The user's primary email address.",
"type": "email_t"
},
"email_addresses": {
"email_addrs": {
"caption": "Email Addresses",
"description": "A list of additional email addresses for the user.",
"type": "email_t",
"is_array": true
"is_array": true,
"type": "email_t"
},
"email_auth": {
"caption": "Email Authentication",
Expand Down Expand Up @@ -1887,6 +1887,11 @@
"description": "The X.500 Distinguished Name (DN) is a structured string that uniquely identifies an entry, such as a user, in an X.500 directory service For example, <code>cn=John Doe,ou=People,dc=example,dc=com</code>.",
"type": "string_t"
},
"ldap_person": {
"caption": "LDAP Person",
"description": "The additonal LDAP attributes that describe a person.",
"type": "ldap_person"
},
"lease_dur": {
"caption": "Lease Duration",
"description": "This represents the length of the DHCP lease in seconds. This is present in DHCP Ack events.",
Expand Down
2 changes: 1 addition & 1 deletion events/discovery/user_inventory.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"caption": "User Inventory Info",
"description": "User Inventory Info events report user inventory data. For example, this can be used to collect information about users by dumping Active Directory data. This event class is meant to be used in conjunction with the <code>person</code> profile to allow capturing extended information about the user.",
"description": "For example, this can be utilized to collect user information by gathering Active Directory data.",
"extends": "discovery",
"name": "user_inventory",
"uid": 3,
Expand Down
12 changes: 6 additions & 6 deletions profiles/person.json → objects/ldap_person.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"caption": "Person",
"description": "The additonal attributes that describe a person or user beyond those required for a user.",
"meta": "profile",
"name": "person",
"caption": "LDAP Person",
"description": "The additonal LDAP attributes that describe a person.",
"name": "ldap_person",
"extends": "object",
"attributes": {
"cost_center": {
"requirement": "optional"
Expand All @@ -14,7 +14,7 @@
"deleted_time": {
"requirement": "optional"
},
"email_addresses": {
"email_addrs": {
"requirement": "optional"
},
"employee_uid": {
Expand Down Expand Up @@ -63,4 +63,4 @@
"requirement": "optional"
}
}
}
}
12 changes: 5 additions & 7 deletions objects/user.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,7 @@
"extends": "_entity",
"name": "user",
"observable": 21,
"profiles": [
"person"
],
"attributes": {
"$include": [
"profiles/person.json"
],
"account": {
"description": "The user's account or the account associated with the user.",
"requirement": "optional"
Expand All @@ -32,6 +26,10 @@
"description": "The administrative groups to which the user belongs.",
"requirement": "optional"
},
"ldap_person": {
"description": "The additonal LDAP attributes that describe a person.",
"requirement": "optional"
},
"name": {
"description": "The username. For example, <code>janedoe1</code>.",
"requirement": "recommended",
Expand Down Expand Up @@ -85,4 +83,4 @@
"uid"
]
}
}
}
Loading