Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#813 Person profile attributes -> object within user #847

Merged
merged 8 commits into from
Nov 9, 2023

Conversation

mikeradka
Copy link
Contributor

@mikeradka mikeradka commented Nov 8, 2023

Related Issue: Item 4 from Issue #813

Description of changes:

Removes the Person profile. All fields from this profile are added directly to the ldap_person object which resides in the user object

@mikeradka mikeradka self-assigned this Nov 8, 2023
@mikeradka mikeradka added enhancement New feature or request description_updates Issues related to missing/incorrect/lacking descriptions of attributes documentation Improvements or additions to documentation labels Nov 8, 2023
@mikeradka mikeradka requested a review from mtharp0 November 8, 2023 21:51
CONTRIBUTING.md Outdated Show resolved Hide resolved
objects/user.json Outdated Show resolved Hide resolved
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
@mikeradka mikeradka requested a review from floydtree November 8, 2023 22:36
@mikeradka mikeradka changed the title 813 person profile #813 Person profile attributes -> object within user Nov 8, 2023
mtharp0
mtharp0 previously approved these changes Nov 9, 2023
floydtree
floydtree previously approved these changes Nov 9, 2023
@mikeradka mikeradka dismissed stale reviews from floydtree and mtharp0 via 509ba1e November 9, 2023 16:46
Signed-off-by: Michael Radka <[email protected]>
@mikeradka mikeradka merged commit 6664c08 into ocsf:main Nov 9, 2023
1 check passed
@mikeradka mikeradka deleted the 813_person_profile branch November 9, 2023 18:05
@pagbabian-splunk pagbabian-splunk added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
description_updates Issues related to missing/incorrect/lacking descriptions of attributes documentation Improvements or additions to documentation enhancement New feature or request v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants