-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#813 Person profile attributes -> object within user #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
mikeradka
requested review from
Aniak5,
jasonbreimer,
zschmerber,
pagbabian-splunk and
floydtree
November 8, 2023 21:49
mikeradka
added
enhancement
New feature or request
description_updates
Issues related to missing/incorrect/lacking descriptions of attributes
documentation
Improvements or additions to documentation
labels
Nov 8, 2023
floydtree
reviewed
Nov 8, 2023
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
mikeradka
changed the title
813 person profile
#813 Person profile attributes -> object within user
Nov 8, 2023
mtharp0
previously approved these changes
Nov 9, 2023
floydtree
previously approved these changes
Nov 9, 2023
Aniak5
reviewed
Nov 9, 2023
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
floydtree
approved these changes
Nov 9, 2023
Aniak5
approved these changes
Nov 9, 2023
mtharp0
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
description_updates
Issues related to missing/incorrect/lacking descriptions of attributes
documentation
Improvements or additions to documentation
enhancement
New feature or request
v1.1.0
Changes marked for v1.1.0 of OCSF
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: Item 4 from Issue #813
Description of changes:
Removes the Person profile. All fields from this profile are added directly to the
ldap_person
object which resides in theuser
object