-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default help behaves properly #678
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
46e89c4
fix: defaultHelp not called with flag value at runtime
peternhale 79939d6
chore(release): 2.8.1-beta.1 [skip ci]
svc-cli-bot 8580dbe
chore: move defaultHelp capture to after all flags have been parsed
peternhale e7409fb
chore: force build
peternhale 7d0badc
fix: force build
peternhale af40698
chore(release): 2.8.1-beta.4 [skip ci]
svc-cli-bot 97219d8
fix: default help behaves properly
peternhale cf91fe1
Merge branch 'main' of github.com:oclif/core into phale/fix-default-help
peternhale 2437f92
Merge branch 'main' into phale/fix-default-help
peternhale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,4 +114,4 @@ | |
"pretest": "yarn build --noEmit && tsc -p test --noEmit --skipLibCheck" | ||
}, | ||
"types": "lib/index.d.ts" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be done in the previous for loop? both iterate over the keys of
this.input.flags
https://github.com/oclif/core/blob/main/src/parser/parse.ts#L268-L290
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristiand391 When defaultHelp is called it is passed all resolved flag values (flags), which can only be done after all previous loops are finished.