fix: default help behaves properly #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-12513575@
cristiand391
reviewed
Apr 4, 2023
src/parser/parse.ts
Outdated
| flags[k] = defaultValue | ||
| } | ||
| } | ||
|
|
||
| for (const k of Object.keys(this.input.flags)) { | ||
| if ((k in flags) && Reflect.has(this.input.flags[k], 'defaultHelp')) { |
There was a problem hiding this comment.
could this be done in the previous for loop? both iterate over the keys of this.input.flags
https://github.com/oclif/core/blob/main/src/parser/parse.ts#L268-L290
There was a problem hiding this comment.
@cristiand391 When defaultHelp is called it is passed all resolved flag values (flags), which can only be done after all previous loops are finished.
cristiand391
approved these changes
Apr 6, 2023
peternhale
added a commit
that referenced
this pull request
Apr 10, 2023
* fix: defaultHelp not called with flag value at runtime @W-12513575@ * chore(release): 2.8.1-beta.1 [skip ci] * chore: move defaultHelp capture to after all flags have been parsed * chore: force build * fix: force build * chore(release): 2.8.1-beta.4 [skip ci] * fix: default help behaves properly @W-12513575@ --------- Co-authored-by: svc-cli-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-12513575@