Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #460 #466

Merged
merged 1 commit into from
Aug 9, 2022
Merged

fix: revert #460 #466

merged 1 commit into from
Aug 9, 2022

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Aug 9, 2022

Reverts the change made in #460

The fix does not work when:

  1. Base Command class sets enableJsonFlag = true
  2. There are multiple subclasses, one of which sets enableJsonFlag = false

In that scenario all subclasses will have the json flag disabled instead of just the one.

This bug is currently affecting plugin-deploy-retrieve so I think we should revert this for now so that we can take our time coming up with a more thorough solution

@mdonnalley mdonnalley self-assigned this Aug 9, 2022
@mdonnalley mdonnalley merged commit 4c28acf into main Aug 9, 2022
@mdonnalley mdonnalley deleted the mdonnalley/revert branch August 9, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant