fix: retain enable json flag get/set apply flag at parse

[peternhale]

No description provided.

[mdonnalley]

You need to also change enableJsonFlag from a getter/setter to static property. Otherwise, it'll still allow the --json flag when a subclass has set enableJsonFlag to false

with getter/setter:

~/code/global-flags » bin/dev status --json
undefined

with static property

~/code/global-flags » bin/dev status --json
Error: Unexpected argument: --json
See more help with --help
    at validateArgs (/Users/mdonnalley/repos/oclif/core/lib/parser/validate.js:11:19)
    at Object.validate (/Users/mdonnalley/repos/oclif/core/lib/parser/validate.js:78:5)
    at Object.parse (/Users/mdonnalley/repos/oclif/core/lib/parser/index.js:30:7)
    at async Status.run (/Users/mdonnalley/code/global-flags/src/commands/status.ts:82:20)
    at async Status._run (/Users/mdonnalley/repos/oclif/core/lib/command.js:65:22)
    at async Config.runCommand (/Users/mdonnalley/repos/oclif/core/lib/config/config.js:270:25)
    at async Object.run (/Users/mdonnalley/repos/oclif/core/lib/main.js:76:5)

Never mind. As I was testing this I realized that deferring the json inclusion to parse means that help isn't ever aware of the json flag... which is why the tests were failing when you tried the solution I suggested.

So now that I know that, I think your original solution might be the best path forward

  static set enableJsonFlag(value: boolean) {
    this._enableJsonFlag = value
    if (value === true) {
      this.globalFlags = jsonFlag
    } else {
      // @ts-ignore
      delete this.globalFlags.json
      // @ts-ignore
      delete this.flags.json
    }
  }

Sorry for being difficult!

[mdonnalley]

QA

Command class with enableJsonFlag = true
✅ run command with --help, shows --json
✅ run command with --json, succeeds
✅ order of enableJsonFlag and flags does not matter

Subclass extends Parent Command class with enableJsonFlag = true
✅ run command with --help, shows --json
✅ run command with --json, succeeds
✅ order of enableJsonFlag and flags does not matter

Subclass with enableJsonFlag = false extends Parent Command class with enableJsonFlag = true
✅ run command with --help, does not show --json
✅ run command with --json, fails
✅ order of enableJsonFlag and flags does not matter