-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use createAsset util function from ocean.js. #14
base: main
Are you sure you want to change the base?
Conversation
@jamiehewitt15 should we create a separate issue for integrating support for sapphire, meaning datatoken template id 4 and accesslist factory? |
Yeah, let's do it seperately |
We have a separate issue for this where accesslists will be integrated #16, let me double check why that address error is popping up. |
Ok, we should still be able to publish assets on barge though? |
Yes, of course, I think the way that we retrive the contract addresses makes that error occur. |
Ok, so we need to fix that first then... |
Hello @jamiehewitt15:
I did not receive the error with accessListFactory address, I used ocean-lib v3.4.4., used remote node on sepolia |
What has changed in barge that would start causing this error? |
First, I started w upgrading ocean contracts docker image. I've seen that I still receive the error w upgraded version of contracts in barge... the same :( |
Ok, we need to figure out what is wrong then |
It comes from ocean.js, I created a PR for it oceanprotocol/ocean.js#1889. Otherwise the functionality of publish is not impacted. |
Ok, let's get the fix in Ocean.js merged first and then test this again |
Fixes #11 .
Changes proposed in this PR: