Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve addresses for remote networks from ocean-contracts as an extra check #12

Open
mariacarmina opened this issue Oct 31, 2024 · 3 comments
Open

Retrieve addresses for remote networks from ocean-contracts as an extra check #12

mariacarmina opened this issue Oct 31, 2024 · 3 comments
Labels
question Further information is requested

Comments

@mariacarmina
Copy link
Member

Retrieve addresses for remote networks from ocean-contracts as an extra check
@jamiehewitt15
Copy link
Member

Why exactly do we need an extra check? And also, why should this be in the vs-code extension? ocean.js should handle the interaction with the contracts

@mariacarmina
Copy link
Member Author

Right now the contract addresses approach is not using ocean.js in the code and maybe that's why it does not pick the right addresses and throws the error you mentioned in this PR #14 (comment).

@jamiehewitt15
Copy link
Member

ok, but then surely we should fix that in ocean.js rather than in the vs-code extension?

@giancu4 giancu4 added the question Further information is requested label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamiehewitt15 @mariacarmina @giancu4