Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#650 - Clean (predvalue, truevalue) columns #664

Merged
merged 15 commits into from
Mar 5, 2024
Merged

#650 - Clean (predvalue, truevalue) columns #664

merged 15 commits into from
Mar 5, 2024

Conversation

kdetry
Copy link
Contributor

@kdetry kdetry commented Feb 22, 2024 •
edited
Loading

Fixes #650

  • All subgraph fetch and code has been updated to address this.
  • All tables and columns that describe predvalue and truevalue have been updated, and named correctly.

@kdetry kdetry changed the title Issue650 #650 - Clean (predvalue, truevalue) columns Feb 22, 2024
@kdetry kdetry marked this pull request as draft February 22, 2024 11:41
@kdetry kdetry marked this pull request as ready for review February 23, 2024 11:48
@kdetry
Copy link
Contributor Author

kdetry commented Feb 29, 2024

@idiom-bytes it is ready for review

idiom-bytes
idiom-bytes approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@idiom-bytes idiom-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @kdetry!

@idiom-bytes idiom-bytes changed the base branch from main to issue685 March 5, 2024 01:49
@idiom-bytes
Copy link
Member

We do not want to change the raw tables on live, this will force a re-fetch.
We're going to merge this into the DuckDB PR and force this change when the rest of the lake updates.

@idiom-bytes idiom-bytes merged commit 34d520b into issue685 Mar 5, 2024
5 checks passed
@idiom-bytes idiom-bytes deleted the issue650 branch March 5, 2024 01:51
@idiom-bytes idiom-bytes mentioned this pull request Mar 5, 2024
Closed
50 tasks
kdetry added a commit that referenced this pull request Mar 6, 2024
@kdetry @idiom-bytes
#650 - Clean (predvalue, truevalue) columns (#664)
b70778f 
* issue650 renaming

* issue650 - test fixes

* issue650 black format

* issue650: fixes after merges

* black fix

* take-back the gql_data_factory from the main branch

* Removed print statements

---------

Co-authored-by: idiom-bytes <[email protected]>
@idiom-bytes idiom-bytes mentioned this pull request Mar 6, 2024
Closed
kdetry added a commit that referenced this pull request Mar 7, 2024
@kdetry @idiom-bytes
Fix #682 - The fetch logic on the lake update process (#751)
3fd4b77 
* last_record_logic is added

* #650 - Clean (predvalue, truevalue) columns (#664)

* issue650 renaming

* issue650 - test fixes

* issue650 black format

* issue650: fixes after merges

* black fix

* take-back the gql_data_factory from the main branch

* Removed print statements

---------

Co-authored-by: idiom-bytes <[email protected]>

* Fixing test

* issue682

* remove unneccessary files

* black

* issue682 removed unnecessary methods

* pylint fix

* pylint fix

---------

Co-authored-by: idiom-bytes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idiom-bytes idiom-bytes idiom-bytes approved these changes

@KatunaNorbert KatunaNorbert Awaiting requested review from KatunaNorbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lake][Schema] Clean (predvalue, truevalue) columns - subgraph, prediction.py & all tables
2 participants
@kdetry @idiom-bytes