[Lake][Schema] Clean (predvalue, truevalue) columns - subgraph, prediction.py & all tables #650
Closed
2 tasks done
Assignees
Labels
Type: Bug
Something isn't working
Comments
idiom-bytes
changed the title
idiom-bytes
added a commit
that referenced
this issue
Mar 5, 2024
* issue650 renaming * issue650 - test fixes * issue650 black format * issue650: fixes after merges * black fix * take-back the gql_data_factory from the main branch * Removed print statements --------- Co-authored-by: idiom-bytes <[email protected]>
|
This is going to change the schema of the raw-tables, which is going to force people to re-fetch a bunch of stuff. Rather than push this now, we merged it into #734 DuckDB Integration PR. After updating the lake/ETL is completed, we can push this out with it so we reduce the number of alterations. |
kdetry
added a commit
that referenced
this issue
Mar 6, 2024
* issue650 renaming * issue650 - test fixes * issue650 black format * issue650: fixes after merges * black fix * take-back the gql_data_factory from the main branch * Removed print statements --------- Co-authored-by: idiom-bytes <[email protected]>
kdetry
added a commit
that referenced
this issue
Mar 7, 2024
* last_record_logic is added * #650 - Clean (predvalue, truevalue) columns (#664) * issue650 renaming * issue650 - test fixes * issue650 black format * issue650: fixes after merges * black fix * take-back the gql_data_factory from the main branch * Removed print statements --------- Co-authored-by: idiom-bytes <[email protected]> * Fixing test * issue682 * remove unneccessary files * black * issue682 removed unnecessary methods * pylint fix * pylint fix --------- Co-authored-by: idiom-bytes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
This was discussed a while ago. This data from subgraph was renamed.
Please clean it up so that inside
subgraph/prediction.pyand related pdr_tables + bronze...Outline:
prediction+truevalparameters should be renamed to be more objective and cleaner.predvalueandtruevalueare the right names to use, and describe the value the user predicted, and the true value accepted for the prediction.DoD:
predvalueandtruevaluehave been updated, and named correctly.The text was updated successfully, but these errors were encountered: