Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Error-messages #367

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Fix/Error-messages #367

merged 2 commits into from
Oct 19, 2020

Conversation

0x3bfc
Copy link
Contributor

@0x3bfc 0x3bfc commented Oct 15, 2020

closes #285

@codeclimate
Copy link

codeclimate bot commented Oct 15, 2020

Code Climate has analyzed commit 3a34c0c and detected 23 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 22

The test coverage on the diff in this pull request is 13.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.3% (0.0% change).

View more on Code Climate.

@alexcos20 alexcos20 self-requested a review October 15, 2020 17:13
alexcos20
alexcos20 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0x3bfc 0x3bfc marked this pull request as ready for review October 19, 2020 06:22
@0x3bfc 0x3bfc merged commit d8704ab into main Oct 19, 2020
@0x3bfc 0x3bfc deleted the fix/error-logging branch October 19, 2020 06:35
@kremalicious kremalicious mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace console.log (.error) with Logger in all web3 related classes
2 participants
@0x3bfc @alexcos20