Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace console.log (.error) with Logger in all web3 related classes #285

Closed
alexcos20 opened this issue Sep 16, 2020 · 4 comments · Fixed by #367
Closed

Replace console.log (.error) with Logger in all web3 related classes #285

alexcos20 opened this issue Sep 16, 2020 · 4 comments · Fixed by #367
Assignees
Labels
Priority: High Type: Bug Something isn't working

Comments

@alexcos20
Copy link
Member

No description provided.

@alexcos20 alexcos20 added Type: Bug Something isn't working Priority: High labels Sep 16, 2020
@alexcos20 alexcos20 self-assigned this Sep 16, 2020
@0x3bfc 0x3bfc self-assigned this Oct 14, 2020
@kremalicious
Copy link
Contributor

#367 only changes the error message output, but does not solve this issue. The goal of this issue to have all logging based on the Logger. Although it looks like it's not actually working as intended right now: #315

@kremalicious kremalicious reopened this Oct 19, 2020
@0x3bfc
Copy link
Contributor

0x3bfc commented Oct 19, 2020

Then this is a duplicate issue ?

@alexcos20
Copy link
Member Author

no, it is not.
we should replace all console. calls with logger.

@0x3bfc
Copy link
Contributor

0x3bfc commented Oct 19, 2020

I see will work on it

@0x3bfc 0x3bfc mentioned this issue Oct 19, 2020
@0x3bfc 0x3bfc closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants