Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] capnp (3.6.0) #24132

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[new release] capnp (3.6.0) #24132

merged 1 commit into from
Jul 21, 2023

Conversation

talex5
Copy link
Contributor

@talex5 talex5 commented Jul 19, 2023

OCaml code generation plugin for the Cap'n Proto serialization framework

CHANGES:

CHANGES:

- Update README to talk about stdint, not uint (reported by @liyishuai).
  Also, remove out-of-date list of runtime packages needed. The build system can sort that out.

- Remove all `inlined` attributes (@talex5 capnproto/capnp-ocaml#87 capnproto/capnp-ocaml#88).
  These cause confusing compiler warnings for users, which can't be disabled automatically,
  and the inlining isn't being used anyway since capnproto/capnp-ocaml#83.

- Fix "Unknown interface" error (@talex5 capnproto/capnp-ocaml#85).
  It reported the UUID of the actual object, not the UUID that was requested.
  Also, add `Registry.pp_interface` for better error messages.

- Minor opam fixes (@talex5 capnproto/capnp-ocaml#84).
  Depend on dune >= 2.3 and don't try to build benchmarks; that only works on some platforms.

- Bump minimum OCaml version to 4.08.
  4.07 doesn't work due to janestreet/base#94.
@avsm
Copy link
Member

avsm commented Jul 20, 2023

Arm32 native code is failing on 4.14


#=== ERROR while compiling capnp.3.6.0 ========================================#
# context              2.2.0~alpha | linux/arm32 | ocaml-base-compiler.4.14.1 | pinned(https://github.com/capnproto/capnp-ocaml/releases/download/v3.6.0/capnp-3.6.0.tbz)
# path                 ~/.opam/4.14/.opam-switch/build/capnp.3.6.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p capnp -j 79 @runtest
# exit-code            1
# env-file             ~/.opam/log/capnp-8-69fb55.env
# output-file          ~/.opam/log/capnp-8-69fb55.out
### output ###
# (cd _build/default/src/tests && /usr/bin/capnp compile -o ../../../install/default/bin/capnpc-ocaml c++.capnp test.capnp test-import.capnp test-iface-import.capnp testLists.capnp testCycles.capnp)
# kj/filesystem-disk-unix.c++:1681: warning: PWD environment variable doesn't match current directory; pwd = /home/opam/.opam/4.14/.opam-switch/build/capnp.3.6.0
# c++.capnp --> c2b2b.mli c2b2b.ml
# test.capnp --> test.mli test.ml
# test-import.capnp --> test_import.mli test_import.ml
# test-iface-import.capnp --> test_iface_import.mli test_iface_import.ml
# testLists.capnp --> testLists.mli testLists.ml
# testCycles.capnp --> testCycles.mli testCycles.ml
# File "src/tests/dune", line 1, characters 0-66:
# 1 | (test
# 2 |  (name run_tests)
# 3 |  (libraries capnp ounit2 base_quickcheck))
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -g -I src/tests/.run_tests.eobjs/byte -I src/tests/.run_tests.eobjs/native -I /home/opam/.opam/4.14/lib/base -I /home/opam/.opam/4.14/lib/base/base_internalhash_types -I /home/opam/.opam/4.14/lib/base/caml -I /home/opam/.opam/4.14/lib/base/shadow_stdlib -I /home/opam/.opam/4.14/lib/base_quickcheck -I /home/opam/.opam/4.14/lib/fieldslib -I /home/opam/.opam/4.14/lib/jane-street-headers -I /home/opam/.opam/4.14/lib/ocplib-endian -I /home/opam/.opam/4.14/lib/ounit2 -I /home/opam/.opam/4.14/lib/ounit2/advanced -I /home/opam/.opam/4.14/lib/ppx_assert/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_bench/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_compare/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_enumerate/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_hash/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_here/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_inline_test/config -I /home/opam/.opam/4.14/lib/ppx_inline_test/runtime-lib -I /home/opam/.opam/4.14/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.14/lib/res -I /home/opam/.opam/4.14/lib/result -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/sexplib0 -I /home/opam/.opam/4.14/lib/splittable_random -I /home/opam/.opam/4.14/lib/stdint -I /home/opam/.opam/4.14/lib/stdlib-shims -I /home/opam/.opam/4.14/lib/time_now -I src/runtime/.capnp.objs/byte -I src/runtime/.capnp.objs/native -intf-suffix .ml -no-alias-deps -open Dune__exe -o src/tests/.run_tests.eobjs/native/dune__exe__Test.cmx -c -impl src/tests/test.ml)
# /opam-tmp/build_de102b_dune/camlasm5f979e.s: Assembler messages:
# /opam-tmp/build_de102b_dune/camlasm5f979e.s:21254: Error: co-processor offset out of range
# /opam-tmp/build_de102b_dune/camlasm5f979e.s:21257: Error: co-processor offset out of range
# /opam-tmp/build_de102b_dune/camlasm5f979e.s:21472: Error: co-processor offset out of range
# /opam-tmp/build_de102b_dune/camlasm5f979e.s:21485: Error: co-processor offset out of range
# /opam-tmp/build_de102b_dune/camlasm5f979e.s:44241: Error: co-processor offset out of range
# /opam-tmp/build_de102b_dune/camlasm5f979e.s:44244: Error: co-processor offset out of range
# /opam-tmp/build_de102b_dune/camlasm5f979e.s:44495: Error: co-processor offset out of range
# /opam-tmp/build_de102b_dune/camlasm5f979e.s:44496: Error: co-processor offset out of range
# File "src/tests/test.ml", line 1:
# Error: Assembler error, input left in file /opam-tmp/build_de102b_dune/camlasm5f979e.s

@talex5
Copy link
Contributor Author

talex5 commented Jul 20, 2023

Sorry - should have mentioned that! The arm32 tests fail due to ocaml/ocaml#10571 (this also affected previous releases).

@avsm avsm merged commit 9326aa9 into ocaml:master Jul 21, 2023
@avsm
Copy link
Member

avsm commented Jul 21, 2023

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants