Fix invalid doc-comments and inline attributes #87
+54
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
talex5
commented
May 7, 2023
•
talex5
commented
- Comments need to go after the fields, not before.
- Removed some inlining attributes; even flambda (with OCaml 5.0.0) complains about these now!
- Fixed dependency on ounit2 (lower-bounds check was failing).
They need to go after the fields, not before.
The code uses ounit2.
talex5
changed the title
Even the flambda version of OCaml (5.0.0) complains about these now.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Jul 19, 2023
CHANGES: - Update README to talk about stdint, not uint (reported by @liyishuai). Also, remove out-of-date list of runtime packages needed. The build system can sort that out. - Remove all `inlined` attributes (@talex5 capnproto/capnp-ocaml#87 capnproto/capnp-ocaml#88). These cause confusing compiler warnings for users, which can't be disabled automatically, and the inlining isn't being used anyway since capnproto/capnp-ocaml#83. - Fix "Unknown interface" error (@talex5 capnproto/capnp-ocaml#85). It reported the UUID of the actual object, not the UUID that was requested. Also, add `Registry.pp_interface` for better error messages. - Minor opam fixes (@talex5 capnproto/capnp-ocaml#84). Depend on dune >= 2.3 and don't try to build benchmarks; that only works on some platforms. - Bump minimum OCaml version to 4.08. 4.07 doesn't work due to janestreet/base#94.
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Update README to talk about stdint, not uint (reported by @liyishuai). Also, remove out-of-date list of runtime packages needed. The build system can sort that out. - Remove all `inlined` attributes (@talex5 capnproto/capnp-ocaml#87 capnproto/capnp-ocaml#88). These cause confusing compiler warnings for users, which can't be disabled automatically, and the inlining isn't being used anyway since capnproto/capnp-ocaml#83. - Fix "Unknown interface" error (@talex5 capnproto/capnp-ocaml#85). It reported the UUID of the actual object, not the UUID that was requested. Also, add `Registry.pp_interface` for better error messages. - Minor opam fixes (@talex5 capnproto/capnp-ocaml#84). Depend on dune >= 2.3 and don't try to build benchmarks; that only works on some platforms. - Bump minimum OCaml version to 4.08. 4.07 doesn't work due to janestreet/base#94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.