Improve completion kinds #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
fixup-completion-kinds
branch
from
bc3a64e to
13cb2ad
Compare
ulugbekna
reviewed
Sep 19, 2021
Introduce these mappings: label -> field variant -> enum member For items without precise kinds, we no longer select a related but inaccurate kind. Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
fixup-completion-kinds
branch
from
13cb2ad to
ac06aef
Compare
This was referenced Feb 7, 2022
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Feb 10, 2022
CHANGES: ## Features - Add better support for code folding: more folds and more precise folds ## Fixes - Fix infer interface code action crash when implementation source does not exist (ocaml/ocaml-lsp#597) - Improve error message when the reason plugin for merlin is absent (ocaml/ocaml-lsp#608) - Fix `chdir` races when running ppx (ocaml/ocaml-lsp#550) - More accurate completion kinds. New completion kinds for variants and fields. Removed inaccurate completion kinds for constructors and types. (ocaml/ocaml-lsp#510) - Fix handling request cancellation (ocaml/ocaml-lsp#616)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce these mappings:
label -> field
variant -> enum member
For items without precise kinds, we no longer select a related but
inaccurate kind.