Improve completion kinds

Introduce these mappings: label -> field variant -> enum member For items without precise kinds, we no longer select a related but inaccurate kind. Signed-off-by: Rudi Grinberg <[email protected]>
ocaml · Sep 19, 2021 · ac06aef · ac06aef
1 parent b841d46
commit ac06aef
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,9 @@
+# Unreleased
+
+- More accurate completion kinds.
+  New completion kinds for variants and fields. Removed inaccurate completion
+  kinds for constructors and types. (#510)
+
 # 1.8.2 (09/14/2021)
 
 - Disable experimental dune support. It was accidentally left enabled.

diff --git a/ocaml-lsp-server/src/compl.ml b/ocaml-lsp-server/src/compl.ml
@@ -17,15 +17,14 @@ end
 let completion_kind kind : CompletionItemKind.t option =
   match kind with
   | `Value -> Some Value
-  | `Constructor -> Some Constructor
-  | `Variant -> None
-  | `Label -> Some Property
-  | `Module
-  | `Modtype ->
-    Some Module
-  | `Type -> Some TypeParameter
+  | `Variant -> Some EnumMember
+  | `Label -> Some Field
+  | `Module -> Some Module
+  | `Modtype -> Some Interface
   | `MethodCall -> Some Method
   | `Keyword -> Some Keyword
+  | `Constructor -> Some Constructor
+  | `Type -> Some TypeParameter
 
 let prefix_of_position ~short_path source position =
   match Msource.text source with