Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround for python failure on OS X #225

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

fdopen
Copy link
Contributor

@fdopen fdopen commented Apr 10, 2018

@yomimono
Copy link
Member

Is there an upstream issue number or PR to which we could refer in a comment here? Otherwise the "temporary" workaround is likely to stay forever.

@fdopen
Copy link
Contributor Author

fdopen commented Apr 10, 2018

There is indeed an upstream issue. Let's see, if they reopen it or if the problem will go away soon enough ...
Homebrew/homebrew-core#26358

@yomimono
Copy link
Member

I wonder about the wisdom of brew upgrade &> /dev/null || true -- I lack an OSX machine to test on and have no personal experience with brew so I'm happy to defer to another maintainer (perhaps @samoht might have an opinion?), but that seems prone to swallowing important error messages and potentially putting the test system in an inconsistent state.

This commit should be reverted once the problem is fixed upstream
@samoht
Copy link
Member

samoht commented Apr 11, 2018

The breakage seems to be introduced by Homebrew/homebrew-core@57bf428 which was a fix for Homebrew/homebrew-core#26287

The history on that file is quite funny as:

depends_on "python" if MacOS.version <= :snow_leopard

got transformed into:

depends_on "python@2"

which seems a bit extreme... Most of it was due to Homebrew/homebrew-core#24714 which didn't give any explanation on why it was done :-/

@samoht samoht merged commit b0d4933 into ocaml:master Apr 11, 2018
@samoht
Copy link
Member

samoht commented Apr 11, 2018

Thanks for the workaround!

@ilovezfs
Copy link

@samoht the relevant links for the removal of the if MacOS.version <= :snow_leopard are
Homebrew/homebrew-core#26287
Homebrew/homebrew-core#26289

@ilovezfs
Copy link

I don't think you'll need the workaround if you use the xcode9.3 Travis image, which I think was created after the python formula became Python 3. See https://docs.travis-ci.com/user/reference/osx/

aantron added a commit to ocsigen/lwt that referenced this pull request Apr 14, 2018
samoht added a commit to samoht/opam-repository that referenced this pull request Aug 2, 2018
CHANGES:

* `OCAML_VERSION=4.06` now uses 4.06.1 instead 4.06.0 (ocaml/ocaml-ci-scripts#218, @yomimono)
* Fix travis docker when the current image is using the system switch
  (ocaml/ocaml-ci-scripts#219, @kit-ty-kate)
* Fix opam 1.3/2.0 json format parsing (ocaml/ocaml-ci-scripts#220, @kit-ty-kate)
* Fix BASE_REMOTE in .travis-docker.sh in CentOS 7 containers (ocaml/ocaml-ci-scripts#222, @gaborigloi)
* update some version numbers in travis readme (ocaml/ocaml-ci-scripts#224, @yomimono)
* (not so) temporary workaround for python failure on OS X (ocaml/ocaml-ci-scripts#225, @fdopen)
* travis-docker: try to make git quieter (ocaml/ocaml-ci-scripts#227, @mor1)
* Add branches for OCaml 4.07 (ocaml/ocaml-ci-scripts#230, @Leonidas-from-XIV)
* Use opam2 by default (ocaml/ocaml-ci-scripts#232, @samoht)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants