Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename old macOS python@2 dependencies #24714

Merged
merged 190 commits into from
Mar 2, 2018

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Mar 2, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Some build.with? need fixing

@ilovezfs ilovezfs added python Python use is a significant feature of the PR or issue do not merge labels Mar 2, 2018
@ilovezfs ilovezfs merged commit 4c00e62 into Homebrew:master Mar 2, 2018
Zimmi48 added a commit to Zimmi48/coq that referenced this pull request Mar 5, 2018
gtksourceview depends transitively on py2cairo which was updated in
Homebrew to depend explicitly on python2 (see Homebrew/homebrew-core#24714):
this makes the python3 install step impossible.
Zimmi48 added a commit to Zimmi48/coq that referenced this pull request Mar 5, 2018
gtksourceview depends transitively on py2cairo which was updated in
Homebrew to depend explicitly on python2 (see Homebrew/homebrew-core#24714):
this makes the python3 install step impossible.
Zimmi48 added a commit to Zimmi48/coq that referenced this pull request Mar 5, 2018
gtksourceview depends transitively on py2cairo which was updated in
Homebrew to depend explicitly on python2 (see Homebrew/homebrew-core#24714):
this makes the python3 install step impossible.

We also remove the libxml2 install step which was failing in a non-fatal way.
Zimmi48 added a commit to Zimmi48/coq that referenced this pull request Mar 5, 2018
gtksourceview depends transitively on py2cairo which was updated in
Homebrew to depend explicitly on python2 (see Homebrew/homebrew-core#24714):
this makes the python3 install step impossible.

We also remove the libxml2 install step which was failing in a non-fatal way.
@Zimmi48
Copy link

Zimmi48 commented Mar 5, 2018

I have no idea what the purpose of this commit was but you might be interested to know that it broke our CI.
See coq/coq#6917.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 5, 2018

@Zimmi48 this is follow up to #24604 which is certainly a breaking change for some stuff. Let me know if you have any questions.

Zimmi48 added a commit to coq/coq that referenced this pull request Mar 9, 2018
gtksourceview depends transitively on py2cairo which was updated in
Homebrew to depend explicitly on python2 (see Homebrew/homebrew-core#24714):
this makes the python3 install step impossible.

We also remove the libxml2 install step which was failing in a non-fatal way.

(cherry picked from commit d183259)
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants