test: reproduction case for #9328 #9372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
force-pushed
the
git-commit-object-repro
branch
from
dff0a37 to
c3c32f5
Compare
rgrinberg
approved these changes
Dec 4, 2023
Alizter
approved these changes
Dec 4, 2023
rgrinberg
reviewed
Dec 4, 2023
Leonidas-from-XIV
force-pushed
the
git-commit-object-repro
branch
2 times, most recently
from
fb8c619 to
c7d3a11
Compare
Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
force-pushed
the
git-commit-object-repro
branch
from
c7d3a11 to
56e8238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces the case in #9328 where the repo contains a
commitobject (not that this serves any purpose, but such cases exist in the wild) and our code breaks.It comments the steps on how to build such a structure in git as this is using some of the git "plumbing" tools that is not particularly well-known, however the Git Book: Git Objects has some information on how to build a commit by hand (they use files in the book but fortunately it also works with commits).