-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: rev_store can't handle symlinks #9328
Comments
In particular, this seems to be the case because it is a broken symlink, |
Fixes ocaml#9328 Signed-off-by: Marek Kubica <[email protected]>
Turns out it is not a symlink, it is a |
Fixes ocaml#9328 Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Fixes ocaml#9328 Signed-off-by: Marek Kubica <[email protected]>
Fixes ocaml#9328 Signed-off-by: Marek Kubica <[email protected]>
So given this turned out not to be about symlinks but Edit: Looks like I forgot to merge, but that's done now so the issue is completed. |
Fixes ocaml#9328 Signed-off-by: Marek Kubica <[email protected]>
Fixes #9328 Signed-off-by: Marek Kubica <[email protected]>
Some opam repositories such as dune-universe/opam-overlays contain symlinks. This causes the rev_store to fail since the parser cannot understand the output of
git-ls
. Dune raisesin this case which under inspection gives the following line from
git-ls
as problematic:Presumably this is due to the fact that
book
is a symlink in that repo and therefore changes the output ofgit-ls
.In this particular case the symlink occurs outside of
packages/
so the case could be made to ignore it, however it seems sensible after discussing with @Leonidas-from-XIV that symlinks could be supported in thefiles/
directory of packages. Therefore the rev_store should be modified to handle them correctly.To reproduce my error above, use the following
dune-workspace
file:The text was updated successfully, but these errors were encountered: