-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dune & dune-release #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work! I'd like @mjambon to comment on the substantive changes before we merge the commits.
Your yojson.opam changes are going to conflict with the ones in the other PR, aren't they? Perhaps these should be separated?
Looks good to me. You should probably make the same changes in opam-repository if you haven't already. We should also replace my name/email by @NathanReb. This can be done later. See #68 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this. I'll let @pmetzger finish the discussion he started.
I suggest using `dune-release opam pkg` (or even that option that directly creates a PR to opam-repository) to generate an `opam` file with the description and synopsis from the repo.
|
Thanks @avsm for the suggestion.
I checked the build and it fails because the Mac builds can't find |
When using dune-release it will generate the documentation automatically and push it to the gh-pages branch which will deploy to this URL.
These had old instructions that weren't correct in the first place and scripts that didn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides that it looks great and will definitely make further work on yojson easier, thanks for your time and effort!
Yeah don't worry about the CI, I'll see what I can do about that! |
There are none yet, so no need for these stanzas.
CHANGES: ### Changes - Use dune as a build system (ocaml-community/yojson#67, @Leonidas-from-XIV) - reraise exceptions in `finish_string` instead of silencing them by raising a `Failure _` - raise finalizer exceptions in `from_channel` and `from_lexbuf` readers ### Fixes - Fix a race condition in builds (ocaml-community/yojson#57, @avsm)
Based on #66.