fix jbuild dependencies for cppo generation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, there is an occasional build race on trying to find `type.ml`: ``` Error: File "yojson.cppo.mli", line 43, characters 0-19 Error: Cannot find included file "type.ml" ``` Also remove a duplicate dependency on `type.ml` in the previous rule as part of this PR. Signed-off-by: Anil Madhavapeddy <[email protected]>
|
Well-spotted, thanks! |
Closed
NathanReb
pushed a commit
to NathanReb/opam-repository
that referenced
this pull request
Dec 27, 2018
CHANGES: ### Changes - Use dune as a build system (ocaml-community/yojson#67, @Leonidas-from-XIV) - reraise exceptions in `finish_string` instead of silencing them by raising a `Failure _` - raise finalizer exceptions in `from_channel` and `from_lexbuf` readers ### Fixes - Fix a race condition in builds (ocaml-community/yojson#57, @avsm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, there is an occasional build race on trying
to find
type.ml:Also remove a duplicate dependency on
type.mlin the previousrule as part of this PR.
Signed-off-by: Anil Madhavapeddy [email protected]