Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw.Util module CPP #163

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Raw.Util module CPP #163

merged 1 commit into from
Apr 4, 2023

Conversation

tmcgilchrist
Copy link
Contributor

Fix for #96

@Leonidas-from-XIV
Copy link
Member

Thanks, sounds like a sensible addition! Could you rebase?

@tmcgilchrist
Add Yojson.Raw.Util module
90c497c 
Provides combinators for extracting fields from Yojson.Raw
values. Matches the API for Yojson.Basic.Util and Yojson.Safe.Util.
@tmcgilchrist
Copy link
Contributor Author

I've rebased @Leonidas-from-XIV the CI failure is caused by ocamlformat not handling CPP files.

Leonidas-from-XIV
Leonidas-from-XIV approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution!

@Leonidas-from-XIV Leonidas-from-XIV merged commit afabb74 into ocaml-community:master Apr 4, 2023
@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Apr 18, 2023
Merged
@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Apr 26, 2023
Merged
Leonidas-from-XIV added a commit to Leonidas-from-XIV/opam-repository that referenced this pull request Apr 26, 2023
@Leonidas-from-XIV
[new release] yojson (2.1.0)
03a6c10 
CHANGES:

*2023-04-26*

### Added

- Add `Yojson.Raw.Util` module to provide combinators for extracting fields
  from `Yojson.Raw.t` values. (@tmcgilchrist, ocaml-community/yojson#163)

- Add `Util.path` function to recurse into an object through a list of keys.
  (@cuihtlauac, @Leonidas-from-XIV, ocaml-community/yojson#157)
@hhugo hhugo mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leonidas-from-XIV Leonidas-from-XIV Leonidas-from-XIV approved these changes

@NathanReb NathanReb Awaiting requested review from NathanReb NathanReb is a code owner

@panglesd panglesd Awaiting requested review from panglesd panglesd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmcgilchrist @Leonidas-from-XIV