Add path function #157
Merged
Add path function #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuihtlauac
requested review from
NathanReb,
panglesd and
Leonidas-from-XIV
as code owners
Leonidas-from-XIV
requested changes
Oct 28, 2022
lib/util.mli
Outdated
| the JSON object [obj], or [`Null] if [l] did no led to an object in | ||
| [obj]. [path [k1; ...; kn] obj] is the same as | ||
| [member kn (... (member k1 obj))] | ||
| @raise Type_error if [obj] is not a JSON object. *) |
There was a problem hiding this comment.
I think in 2022 we shouldn't be adding more unsafe functions that throw exceptions. It would be better to return t option here and I am somewhat unsure that returning `Null is a behavior that makes sense in OCaml. If I saw a function like this I would not expect path ["missing"] (Assoc [])to return ``Null``, I would rather expect it to throw Not_found following the stdlib.
(I am aware that it uses member for which the exact same concerns apply which unfairly gets a free pass for being like this since forever)
Allows recurisve access to nested object fields using a list of keys
Leonidas-from-XIV
approved these changes
Apr 18, 2023
|
@panglesd Can you take a look at this PR and weight in whether you think this is reasonable? It's a bit unusual as the API is bit more exception-safe than the rest. |
panglesd
approved these changes
Apr 18, 2023
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Apr 26, 2023
CHANGES: *2023-04-26* ### Added - Add `Yojson.Raw.Util` module to provide combinators for extracting fields from `Yojson.Raw.t` values. (@tmcgilchrist, ocaml-community/yojson#163) - Add `Util.path` function to recurse into an object through a list of keys. (@cuihtlauac, @Leonidas-from-XIV, ocaml-community/yojson#157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows recurisve access to nested object fields using a list of keys