feat(#939): Upgrade eo up to the 0.49.4 version
#942
Conversation
|
Blocked by objectionary/eo#3547 |
|
Blocked by objectionary/lints#127 |
volodya-lombrozo
changed the title
eo up to the 0.46.0 versioneo up to the 0.48.2 version
volodya-lombrozo
changed the title
eo up to the 0.48.2 versioneo up to the 0.49.2 version
| @@ -150,7 +150,7 @@ public String name() { | |||
| public Bytecode toBytecode() { | |||
| final Node xmir = this.xml.value(); | |||
| try { | |||
| new StrictXML(new XMLDocument(new XMLDocument(xmir).toString())).validate(); | |||
| new StrictXmir(new XMLDocument(new XMLDocument(xmir).toString())).inner(); | |||
| return new XmlProgram(xmir).bytecode().bytecode(); | |||
There was a problem hiding this comment.
@volodya-lombrozo you can do here just
return new XmlProgram(new StrictXmir(new XMLDocument(xmir)).inner()).bytecode().bytecode()There was a problem hiding this comment.
@maxonfjvipon I can't remove extra new XMLDocument. It's one more bug in jcabi-xml. You can try to remove it and you will see that unit tests fail.
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 13min). |
volodya-lombrozo
changed the title
eo up to the 0.49.2 versioneo up to the 0.49.4 version
|
@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (573 >= 200); -16 for the lack of code review; +24 to give you at least something. Please, keep them coming. Your running balance is +4. |
Upgrade
eoversion up to0.49.2. Additionally, in this PR I:abstractobjects.jeo.seq.of2lints#127 (comment)objectionary/lintsdependency to check generatedXMIRtesting of generated XMIR is not using our "lints" #938jcabi-xmlto the0.32.0versionRelated to #939.