Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(#3804): Implemented phi-to-xmir cache. #3865

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

bug(#3804): Implemented phi-to-xmir cache. #3865

wants to merge 5 commits into from

Conversation

ArtemGet
Copy link
Contributor

Implemented cache in UnphiMojo. I decided to leave tests Disabled since empty hash is not cacheable. Added sync tojos todo.

Ref #3804

@ArtemGet
Copy link
Contributor Author

@maxonfjvipon Could you take a look, please?

@maxonfjvipon
Copy link
Member

@ArtemGet if you enable these disabled tests - will they pass?

@ArtemGet
Copy link
Contributor Author

@maxonfjvipon Nope, because this tests needs hash otherwise cache file will not be created. I could add one more test that check that parsing will be skipped if target older than source e.t.c (But I dont found any tests like that, all test for other Mojo's requires hash).

@maxonfjvipon
Copy link
Member

@ArtemGet

  1. empty hash used in Footprint should not lead to behavior where file is not created. If so - it's a bug
  2. Since we use empty hash for now - let's test that it works with empty hash

Otherwise it looks like you changed the functionality but it's not covered by any tests.

So the tests must be enabled and let's check that they work with empty hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtemGet @maxonfjvipon