Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3177 dependencies parsing #3178

Merged
merged 2 commits into from
May 9, 2024
Merged

3177 dependencies parsing #3178

merged 2 commits into from
May 9, 2024

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented May 9, 2024 •
edited
Loading

Closes #3177
Added checking of wide objects in add-rust.xsl

@levBagryansky
Copy link
Member Author

@maxonfjvipon WDYT

maxonfjvipon
maxonfjvipon approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky LGTM! Thanks

@yegor256
Copy link
Member

yegor256 commented May 9, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 9, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit fe57bd3 into objectionary:master May 9, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented May 9, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 21min)

@levBagryansky levBagryansky deleted the 3177_dependencies-parsing branch May 9, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to build cargo project
4 participants
@levBagryansky @yegor256 @rultor @maxonfjvipon