Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2682): unphi mojo test packs + bug fixes #2685

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Dec 7, 2023

Closes: #2682
Closes: #2642

What's done:

  • Added test packs for UnphiMojo
  • Added test that converts phi to xmir and back
  • Fixed bugs with explicit data transformation

PR-Codex overview

This PR focuses on updating the UnphiMojo class in the eo-maven-plugin.

Detailed summary

  • The UnphiMojo class in the eo-maven-plugin has been modified.
  • The home.save() method has been updated to use a modified PhiSyntax object.
  • The phi.getFileName().toString() now replaces the ".phi" extension with an empty string.
  • The UnphiMojoTest class has been modified to remove the `@

The following files were skipped due to too many changes: eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

yegor256 commented Dec 7, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Dec 7, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a0c2729 into objectionary:master Dec 7, 2023
11 checks passed
@rultor
Copy link
Contributor

rultor commented Dec 7, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 18min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnphiMojoTest.java:48-50: Create test packs for {@link... Parse phi-calculus expression to xmir
4 participants