-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#2437): data primitives without delta attribute #2583
feat(#2437): data primitives without delta attribute #2583
Conversation
ea6014b
to
b215348
Compare
@yegor256 please have a look |
[] > string | ||
[data] > string | ||
data > @ | ||
data > as-bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon maybe we can just name it as-bytes
instead of data
?
@@ -146,6 +147,7 @@ void copies() { | |||
} | |||
|
|||
@Test | |||
@Disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon no puzzle for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon a few small comments above |
* rust-find-returns-int, rust-plus, rust-bind-not-fails, rust-is-string, rust-copy-not-fails, | ||
* rust-is-byte-array, rust-bind-to-copy, rust-put-to-copy, rust-returns-positive-double, | ||
* rust-returns-negative-double, rust-dataize-not-fails, | ||
* UniverseDefaultTest#bindsCopyToAbstract, UniverseDefaultTest#putsToCopy, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
@yegor256 please have a look one more time |
@rultor merge |
Closes: #2437
PR-Codex overview
This PR focuses on making various changes and improvements to the codebase.
Detailed summary
EOint$EOas_bytes.java
andEOfloat$EOas_bytes.java
.DELTA
in theAttr.java
file.EOstdoutTest.java
file by modifying thetake()
method.EOtupleEOatTest.java
file by changing thetake()
method.pom.xml
file.DiscoverMojoTest.java
file.int.eo
,float.eo
,bool.eo
, andstring.eo
files.as-bytes
attribute in thestring.eo
file.PhWithTest.java
file.AtVararg.java
file by updating theput()
method.EObytes$EOeq.java
file by modifying theequals()
method.tuple-to-java.yaml
file.TranspileMojo.java
file by removing unused imports.add_rust.xsl
file by modifying thecode
attribute.EOintEOeqTest.java
file.bool-tests.eo
file by