Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2437): data primitives without delta attribute #2583

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Nov 13, 2023

Closes: #2437


PR-Codex overview

This PR focuses on making various changes and improvements to the codebase.

Detailed summary

  • Deleted two files: EOint$EOas_bytes.java and EOfloat$EOas_bytes.java.
  • Added a new attribute DELTA in the Attr.java file.
  • Updated the EOstdoutTest.java file by modifying the take() method.
  • Modified the EOtupleEOatTest.java file by changing the take() method.
  • Added a new dependency in the pom.xml file.
  • Updated the test cases in the DiscoverMojoTest.java file.
  • Added new attributes and methods in the int.eo, float.eo, bool.eo, and string.eo files.
  • Updated the as-bytes attribute in the string.eo file.
  • Updated the test cases in the PhWithTest.java file.
  • Modified the AtVararg.java file by updating the put() method.
  • Updated the EObytes$EOeq.java file by modifying the equals() method.
  • Updated the test cases in the tuple-to-java.yaml file.
  • Updated the TranspileMojo.java file by removing unused imports.
  • Updated the add_rust.xsl file by modifying the code attribute.
  • Updated the test cases in the EOintEOeqTest.java file.
  • Updated the bool-tests.eo file by

The following files were skipped due to too many changes: eo-maven-plugin/src/test/resources/org/eolang/maven/pre/pre-data.yaml, eo-maven-plugin/pom.xml, eo-runtime/src/main/java/EOorg/EOeolang/EOrust.java, eo-maven-plugin/src/test/java/org/eolang/maven/BinarizeParseMojoTest.java, eo-runtime/src/test/java/org/eolang/MainTest.java, eo-runtime/src/test/eo/org/eolang/int-tests.eo, eo-runtime/src/test/java/org/eolang/PhDefaultTest.java, eo-maven-plugin/src/test/resources/org/eolang/maven/packs/pre/data-as-bytes.yaml, eo-runtime/src/test/java/org/eolang/DataTest.java, eo-parser/src/test/resources/org/eolang/parser/packs/explicit-data.yaml, eo-runtime/src/main/java/org/eolang/Dataized.java, eo-maven-plugin/src/main/resources/org/eolang/maven/pre/data.xsl, eo-runtime/src/main/java/org/eolang/Data.java, eo-runtime/src/test/eo/org/eolang/rust-tests.eo, eo-runtime/src/main/java/org/eolang/Param.java, eo-parser/src/main/resources/org/eolang/parser/explicit-data.xsl

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon maxonfjvipon force-pushed the feat/#2437/primitives-with-data-bytes branch from ea6014b to b215348 Compare November 14, 2023 08:34
@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

[] > string
[data] > string
data > @
data > as-bytes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon maybe we can just name it as-bytes instead of data?

@@ -146,6 +147,7 @@ void copies() {
}

@Test
@Disabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon no puzzle for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256 there's one here

@yegor256
Copy link
Member

@maxonfjvipon a few small comments above

* rust-find-returns-int, rust-plus, rust-bind-not-fails, rust-is-string, rust-copy-not-fails,
* rust-is-byte-array, rust-bind-to-copy, rust-put-to-copy, rust-returns-positive-double,
* rust-returns-negative-double, rust-dataize-not-fails,
* UniverseDefaultTest#bindsCopyToAbstract, UniverseDefaultTest#putsToCopy,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look one more time

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Nov 14, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1325da6 into objectionary:master Nov 14, 2023
10 checks passed
@rultor
Copy link
Contributor

rultor commented Nov 14, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 27min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

int, float, string, and bool must encapsulate bytes
3 participants