Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on Sonar results #2006

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Fail on Sonar results #2006

merged 2 commits into from
Apr 19, 2023

Conversation

mximp
Copy link
Contributor

@mximp mximp commented Apr 19, 2023

closes #1897


PR-Codex overview

This PR adds the -Dsonar.qualitygate.wait=true flag to the SonarCloud workflow in the .github/workflows/sonar.yml file.

Detailed summary

  • Added the -Dsonar.qualitygate.wait=true flag to the mvn command in the SonarCloud workflow.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@mximp
Copy link
Contributor Author

mximp commented Apr 19, 2023

@yegor256 please check

@yegor256 yegor256 merged commit e117f1a into objectionary:master Apr 19, 2023
@mximp mximp deleted the patch-1 branch April 19, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sonarcube is complaining about our quality of code
2 participants